-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prune some build artifacts on CI to speed up caching #1580
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This script deletes final build artifacts, which are often large and cannot be reused if any backend code has changed. Dependencies and incremental artifacts are left in place.
Looks to be a big savings, Nice fined! |
Running `cargo test` produces a set of normal build artifacts in addition to test versions of each. (That is, running `cargo build` after `cargo test` is a no-op.) By removing the explicit `cargo build` invocation the test dependencies can begin building in parallel a bit sooner.
Building and uploading the cache now takes about 130 seconds on the stable channel. On beta and nightly it takes around 90 seconds. The cache on stable is larger because of additional clippy and npm files. The caching behavior seems to be consistent enough to switch back to the default setting of 180 seconds.
jtgeibel
changed the title
[WIP] Prune some build artifacts on CI to speed up caching
Prune some build artifacts on CI to speed up caching
Dec 22, 2018
Thanks for the encouragement @Eh2406! Here is a summary of the results I'm seeing:
bors: r+ |
bors-voyager bot
added a commit
that referenced
this pull request
Dec 22, 2018
1580: Prune some build artifacts on CI to speed up caching r=jtgeibel a=jtgeibel This script deletes final build artifacts, which are often large and cannot be reused if any backend code has changed. Dependencies and incremental artifacts are left in place. Co-authored-by: Justin Geibel <jtgeibel@gmail.com>
Build succeeded |
This was referenced Jan 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This script deletes final build artifacts, which are often large and
cannot be reused if any backend code has changed. Dependencies and
incremental artifacts are left in place.