Skip to content

Second try making the graph legend fit without wrap #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2015

Conversation

mdinger
Copy link
Contributor

@mdinger mdinger commented Aug 10, 2015

Should be good for at least a 100,000 downloads and 5 digit versions without resorting to wrapping. It's shifted because staying centered tends to keep it too far to the right (the diagram stays centered while the legend gets closer to the edge).

Regex crate:
regex

@alexcrichton
Copy link
Member

What's the wrapping you see today? The screenshot looks like what I see today for regex and it looks ok.

@mdinger
Copy link
Contributor Author

mdinger commented Aug 11, 2015

Regex at crates.io taken just now:
regex_on_crates_io

I tried proxy directly to crates.io instead of heroku when testing my patch but I don't think it could have modified crates.io but I don't really know. What's the lag time in crates.io being updated by the repository? My previous fix might have fixed it and it just hadn't appeared when I looked last time. If the revert hasn't landed yet, it could be that.

[EDIT] Would different server locations be updated slower than others?

@mdinger
Copy link
Contributor Author

mdinger commented Aug 11, 2015

I just confirmed that it still line-wraps in a new firefox profile also.

@alexcrichton
Copy link
Member

Ok, may just be odd browser/size differences.

This site doesn't auto-deploy, I have to push manually, I'll probably do so once I've gotten through #177

alexcrichton added a commit that referenced this pull request Aug 11, 2015
Second try making the graph legend fit without wrap
@alexcrichton alexcrichton merged commit 6451095 into rust-lang:master Aug 11, 2015
@mdinger mdinger deleted the graph_legend2 branch August 11, 2015 06:54
@mdinger
Copy link
Contributor Author

mdinger commented Aug 11, 2015

Okay, that's cool.

@mdinger
Copy link
Contributor Author

mdinger commented Aug 18, 2015

@alexcrichton Did you deploy this? This is a regex crate screenshot taken just now (8/17):

regex_aug17

If you already deployed and it still doesn't fix it, I have no idea what the issue is. It was fixed it when I tried locally.

@alexcrichton
Copy link
Member

Ah no I haven't deployed this just yet, I'm finishing up with @gankro's work on teams and I hope to deploy this and that both soon

@mdinger
Copy link
Contributor Author

mdinger commented Aug 18, 2015

Ah, silly me. I should've looked at that PR. I thought for some reason that PR would've been finished the day you mentioned it. Don't know what I was thinking. Looking at the PR further didn't even occur to me.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants