Add missing foreign key constraint for columns badges.crate_id. #1840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we may already have entries in the `badges` table referring to crates that don't exist, we need to delete these entries before creating the foreign key constraint. This is a destructive operation in the sense that it cannot be reverted, but it should only delete rows that should have been deleted together with the crates they belong to. We have a test to verify that all columns called `crate_id` are actually foreign keys referring to `crates.id`. However, the query for the relevant columns contains the filter `contype = 'f'`, effectively limiting the result to columns that already have foreign key constraints. This change fixes the query to also allow `contype IS NULL`. In addition, I modified the query to only verify tables in the schema `public`. This is useful for an integration test for the database dumps in rust-lang#1800.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
I've confirmed that all rows in production to be deleted are in fact rows that should have already been deleted. @bors: r+ |
|
📌 Commit 7ef85f5 has been approved by |
bors
added a commit
that referenced
this pull request
Sep 18, 2019
Add missing foreign key constraint for columns badges.crate_id. Since we may already have entries in the `badges` table referring to crates that don't exist, we need to delete these entries before creating the foreign key constraint. This is a destructive operation in the sense that it cannot be reverted, but it should only delete rows that should have been deleted together with the crates they belong to. We have a test to verify that all columns called `crate_id` are actually foreign keys referring to `crates.id`. However, the query for the relevant columns contains the filter `contype = 'f'`, effectively limiting the result to columns that already have foreign key constraints. This change fixes the query to also allow `contype IS NULL`. In addition, I modified the query to only verify tables in the schema `public`. This is useful for an integration test for the database dumps in #1800.
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we may already have entries in the
badgestable referring to crates that don't exist, weneed to delete these entries before creating the foreign key constraint. This is a destructive
operation in the sense that it cannot be reverted, but it should only delete rows that should have
been deleted together with the crates they belong to.
We have a test to verify that all columns called
crate_idare actually foreign keys referring tocrates.id. However, the query for the relevant columns contains the filtercontype = 'f',effectively limiting the result to columns that already have foreign key constraints. This change
fixes the query to also allow
contype IS NULL.In addition, I modified the query to only verify tables in the schema
public. This is useful foran integration test for the database dumps in #1800.