Skip to content

Fixed versions suggestion #1857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 3, 2019
Merged

Fixed versions suggestion #1857

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c4bfb53
Fixed version suggestion logic.
hbina Sep 29, 2019
90f7533
Minute change
hbina Sep 29, 2019
e7abdfc
Update version.js
locks Oct 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions app/routes/crate/version.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,14 +43,29 @@ export default Route.extend({
.get('versions')
.then(versions => {
const latestStableVersion = versions.find(version => {
// Find the latest version that is stable AND not-yanked.
if (!isUnstableVersion(version.get('num')) && !version.get('yanked')) {
return version;
}
});

if (latestStableVersion == null) {
// If no stable version exists, fallback to `maxVersion`
params.version_num = maxVersion;
// Cannot find any version that is stable AND not-yanked.
// The fact that "maxVersion" itself cannot be found means that
// we have to fall back to the latest one that is unstable....
const latestUnyankedVersion = versions.find(version => {
// Find the latest version that is stable AND not-yanked.
if (!version.get('yanked')) {
return version;
}
});

if (latestStableVersion == null) {
// There's not even any unyanked version...
params.version_num = maxVersion;
} else {
params.version_num = latestUnyankedVersion;
}
} else {
params.version_num = latestStableVersion.get('num');
}
Expand Down