front-end: Add email notification preferences #1913
Conversation
This commit adds the front-end capabilities to coincide with the API endpoint that was built on the server. There's also a small but fixed in the api-token-row that's fixed.
|
r? @jtgeibel (rust_highfive has picked a reviewer for you, use r? to override) |
|
☔ The latest upstream changes (presumably #1922) made this pull request unmergeable. Please resolve the merge conflicts. |
There was a problem hiding this comment.
This looks so great, I love it!!!
I just have a wording tweak suggestion, interested to know what you think.
Also a feature request that you can do in another PR if you want, I was thinking of people who own lots of crates and was thinking it would be nice to have a "check/uncheck all" mechanism. What do you think?
Thank you so much for this!!!
Also add wording to clarify that crate owners may turn notifications on or off for each crate.
|
Here's what Select/Deselect All button could look like based on the most recent commit:
|
|
This looks great!! Thank you so much!! @bors r+ |
|
📌 Commit 12ce748 has been approved by |
…10cents front-end: Add email notification preferences This commit adds the front-end capabilities to coincide with the API endpoint that was built on the server. There's also a small bug fixed in the api-token-row; it was throwing an error every time the "/me" route was loaded. This PR addresses the second item in #1895. I like how the UI ended up, but it may very well be creators bias 😄. If this doesn't work, then I'll be happy to iterate! ### Screenshot of a crate with notifications on and one that's off 
|
☀️ Test successful - checks-travis |
This commit adds the front-end capabilities to coincide with the API endpoint that was built on the server. There's also a small bug fixed in the api-token-row; it was throwing an error every time the "/me" route was loaded.
This PR addresses the second item in #1895.
I like how the UI ended up, but it may very well be creators bias 😄. If this doesn't work, then I'll be happy to iterate!
Screenshot of a crate with notifications on and one that's off