Remove some usage of unwrap()
#2072
Conversation
|
r? @sgrif (rust_highfive has picked a reviewer for you, use r? to override) |
This commit reduces the usage of unwrap within the request/response lifecycle, and documents a few remaining cases. Usage of unwrap in tests, binaries, or server boot code is generally okay and was not reviewed. Remaining work: * Some usage of unwrap in `git.rs` and `srcc/tasks/` background jobs. This code is not directly in the request/response lifecycle, but should be reviewed. * Current usage in middleware seems okay, but could be documented. In most cases, such as with the handler in `AroundMiddleware`, the conduit API ensures a handler is set.
jtgeibel
force-pushed
the
fix/remove-some-unwraps
branch
from
14a1859 to
7aee526
Compare
|
I've push a commit to add impls for
Yeah, looks like it was missed before and I has already removed the @bors r=carols10cents |
|
📌 Commit a318cb3 has been approved by |
Remove some usage of `unwrap()` This commit reduces the usage of unwrap within the request/response lifecycle, and documents a few remaining cases. Usage of unwrap in tests, binaries, or server boot code is generally okay and was not reviewed. Remaining work: * Some usage of unwrap in `git.rs` and `src/tasks/` background jobs. This code is not directly in the request/response lifecycle, but should be reviewed. * Current usage in middleware seems okay, but could be documented. In most cases, such as with the handler in `AroundMiddleware`, the conduit API ensures a handler is set.
|
☀️ Test successful - checks-travis |
This commit reduces the usage of unwrap within the request/response
lifecycle, and documents a few remaining cases. Usage of unwrap in
tests, binaries, or server boot code is generally okay and was not
reviewed.
Remaining work:
git.rsandsrc/tasks/background jobs.This code is not directly in the request/response lifecycle, but
should be reviewed.
In most cases, such as with the handler in
AroundMiddleware, theconduit API ensures a handler is set.