Skip to content

Update Ember (again) #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 15, 2015
Merged

Update Ember (again) #214

merged 2 commits into from
Nov 15, 2015

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Nov 13, 2015

This PR updates the Ember app to the most recent v1.13 version and fixes the remaining bug mentioned in #208

@alexcrichton
Copy link
Member

Thanks!

I'll deploy this to staging now and then hopefully get around to prod tomorrow

alexcrichton added a commit that referenced this pull request Nov 15, 2015
@alexcrichton alexcrichton merged commit 4fec724 into rust-lang:master Nov 15, 2015
@alexcrichton
Copy link
Member

Hm it seems like there's a bit of a more deep-seated issue here that may warrant some more investigation, for example if you go to the all crates index page and click on cargo you'll get the same "Version null does not exist" error again

@Turbo87
Copy link
Member Author

Turbo87 commented Nov 16, 2015

That's what I feared... I guess this is related to #208 (comment). In this case the crates index page returns the crates with versions: null which unfortunately gets converted to versions: [] and appears as if it was sideloaded.

I suspected this to be a bug in Ember Data, but this seems to be expected behavior. What we need to do is implement an adapter/serializer which filters out versions: null and replaces it with undefined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants