Add tests for the API token list #2251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtgeibel
approved these changes
Mar 6, 2020
Member
jtgeibel
left a comment
jtgeibel
left a comment
There was a problem hiding this comment.
This looks excellent! Once you fix the timezone shenanigans you mentioned, I'll r+.
Member
Oops, I meant feel free to bors r=me. |
Member
Author
Contributor
|
📌 Commit 736f5e9 has been approved by |
Contributor
Contributor
|
☀️ Test successful - checks-travis |
bors
added a commit
that referenced
this pull request
Mar 20, 2020
tests/api-token: Add Percy snapshot This PR improves upon #2251 by adding a Percy snapshot to the API tokens test. This will ensure that the styling of the `/me` route will not get broken in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a few basic application test for the API token list on the
/meroute. This should help in preventing regressions like mentioned in #2211.r? @jtgeibel