Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cargo guide link to the top nav bar. #267

Merged
merged 1 commit into from
Feb 29, 2016
Merged

Add Cargo guide link to the top nav bar. #267

merged 1 commit into from
Feb 29, 2016

Conversation

birkenfeld
Copy link
Contributor

(This is just a quick change; haven't tested locally if it looks like it is supposed to.)

I think that the links to the cargo docs are much too hard to find at the bottom of the page. (Especially since you can't find it by searching for "doc".) Neither is the "Getting started" button on the index page a good entry point, since it is only present on that page.

This is kind of what #139 suggests, but without the full drop-down.

@alexcrichton
Copy link
Member

Can you provide a screenshot of what this ends up looking like?

@birkenfeld
Copy link
Contributor Author

Here you go:
2016-02-16-201132_1920x1080_scrot

@alexcrichton
Copy link
Member

Thanks! It may be good to keep doc.crates.io in sync with crates.io as much as possible, however. The current deviation is from the "log in" link (the links at the bottom match), so I'm somewhat hesitant to allow the two to deviate more?

@birkenfeld
Copy link
Contributor Author

Not sure that goal is more important than quick access to the page you want. But I wouldn't mind them to become more in sync by putting the "Documentation" popup from doc.crates.io on crates.io as well (instead of this patch).

BTW, if you want them to be in sync, you might also want to look at the stylesheet - for example, crates.io specifies "Helvetica Neue",...,sans-serif for font-face, while doc.crates.io specifies only sans-serif.

@alexcrichton
Copy link
Member

Yeah perhaps we can go that route of adding the whole documentation link instead? I think that's what #139 is basically asking for anyway

@birkenfeld
Copy link
Contributor Author

I'll see what I can do :)

@birkenfeld
Copy link
Contributor Author

Updated, new screenshot below. Note that doc.crates.io has a style for dropdowns that makes the "Documentation v" header look depressed and reverses the arrow while the dropdown is open. crates.io doesn't, currently, but neither does it for the user dropdown menu.

2016-02-26-103808_1920x1080_scrot

@birkenfeld
Copy link
Contributor Author

Reported the style inconsistencies in #273.

@alexcrichton
Copy link
Member

Thanks!

alexcrichton added a commit that referenced this pull request Feb 29, 2016
Add Cargo guide link to the top nav bar.
@alexcrichton alexcrichton merged commit dc67d7b into rust-lang:master Feb 29, 2016
@birkenfeld
Copy link
Contributor Author

And it's already live. Great!

@birkenfeld birkenfeld deleted the top-guide branch February 29, 2016 19:23
@alexcrichton
Copy link
Member

Aww looks like the spacing may be a bit off though?

https://i.imgur.com/XvsZ5Js.jpg

@birkenfeld
Copy link
Contributor Author

I assume you mean the spacing around the separator? The same happens with the user dropdown though.

As long as you're not logged in, there is less space between separator and menu item (there's no dropdown).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants