-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cargo guide link to the top nav bar. #267
Conversation
Can you provide a screenshot of what this ends up looking like? |
Thanks! It may be good to keep doc.crates.io in sync with crates.io as much as possible, however. The current deviation is from the "log in" link (the links at the bottom match), so I'm somewhat hesitant to allow the two to deviate more? |
Not sure that goal is more important than quick access to the page you want. But I wouldn't mind them to become more in sync by putting the "Documentation" popup from doc.crates.io on crates.io as well (instead of this patch). BTW, if you want them to be in sync, you might also want to look at the stylesheet - for example, crates.io specifies |
Yeah perhaps we can go that route of adding the whole documentation link instead? I think that's what #139 is basically asking for anyway |
I'll see what I can do :) |
Reported the style inconsistencies in #273. |
Thanks! |
Add Cargo guide link to the top nav bar.
And it's already live. Great! |
I assume you mean the spacing around the separator? The same happens with the user dropdown though. As long as you're not logged in, there is less space between separator and menu item (there's no dropdown). |
(This is just a quick change; haven't tested locally if it looks like it is supposed to.)
I think that the links to the cargo docs are much too hard to find at the bottom of the page. (Especially since you can't find it by searching for "doc".) Neither is the "Getting started" button on the index page a good entry point, since it is only present on that page.
This is kind of what #139 suggests, but without the full drop-down.