-
Notifications
You must be signed in to change notification settings - Fork 643
Fix mismatch in crate versions between pages #2751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
For example with `clap`, in the search results (/search?q=clap) the crate version was shown as `3.0.0-beta.1`, whereas on the crate's page (/crates/clap) it was shown as `2.33.3`. The issue was that the search results were showing the *maximum* version, not the newest version, which I believe is what the crate page was showing. Also added a missing "the" in a hover title.
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @sgrif (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
I'm new to both Ember and working on crates.io, so I would appreciate it if you could make sure that I'm understanding the crates.io versioning models correctly! |
The version template which represents the crate page (/crates/clap) seems to be referencing an attribute on the controller called Lines 11 to 12 in e308ecf
|
@@ -28,7 +28,7 @@ | |||
<div local-class="updated-at" > | |||
{{svg-jar "latest-updates" height="32" width="32"}} | |||
<span> | |||
<abbr title="The last time crate was updated">Updated:</abbr> | |||
<abbr title="The last time the crate was updated">Updated:</abbr> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or this maybe to match the other hover titles?
<abbr title="The last time the crate was updated">Updated:</abbr> | |
<abbr title="Last time crate was updated">Updated:</abbr> |
So this probably shouldn't be |
☔ The latest upstream changes (presumably #2825) made this pull request unmergeable. Please resolve the merge conflicts. Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:
|
Fixes #2710.
For example with
clap
, in the search results (/search?q=clap) thecrate version was shown as
3.0.0-beta.1
, whereas on the crate's page(/crates/clap) it was shown as
2.33.3
.The issue was that the search results were showing the maximum version,
not the newest version, which I believe is what the crate page was
showing.
Also added a missing "the" in a hover title.
@rustbot modify labels: A-frontend A-versions C-bug