Simplify crate.version route implementation
#3175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and `newest_version` This matches what the backend currently provides
…version` and `newest_version`
Turbo87
force-pushed
the
default-version
branch
from
53d71b8 to
52f086f
Compare
|
@bors r+ |
|
📌 Commit 52f086f has been approved by |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
defaultVersionproperty on thecratemodel and uses it in thecrate.version(andcrate.index) route to determine which version to display by default. This lets us get rid of thesemverdependency in that route and puts the backend in charge of telling us what to display by default. This will allow us to address #654 in the near future, since the newdefaultVersionproperty can be used in the search results too.This is probably best reviewed commit-by-commit :)
r? @pichfl