Skip to content

CrateRow: Use defaultVersion for crate version display #3179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 14, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions app/components/crate-row.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,17 @@
{{@crate.name}}
</a>
{{/let}}
<span local-class="version" data-test-version>v{{@crate.max_version}}</span>
<CopyButton
@copyText='{{@crate.name}} = "{{@crate.max_version}}"'
title="Copy Cargo.toml snippet to clipboard"
local-class="copy-button"
>
{{svg-jar "copy" alt="Copy Cargo.toml snippet to clipboard"}}
</CopyButton>
{{#if @crate.defaultVersion}}
<span local-class="version" data-test-version>v{{@crate.defaultVersion}}</span>
<CopyButton
@copyText='{{@crate.name}} = "{{@crate.defaultVersion}}"'
title="Copy Cargo.toml snippet to clipboard"
local-class="copy-button"
data-test-copy-toml-button
>
{{svg-jar "copy" alt="Copy Cargo.toml snippet to clipboard"}}
</CopyButton>
{{/if}}
</div>
<div local-class="description" data-test-description>
{{ truncate-text @crate.description }}
Expand Down
57 changes: 57 additions & 0 deletions tests/components/crate-row-test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
import { render } from '@ember/test-helpers';
import { setupRenderingTest } from 'ember-qunit';
import { module, test } from 'qunit';

import { hbs } from 'ember-cli-htmlbars';

import setupMirage from '../helpers/setup-mirage';

module('Component | CrateRow', function (hooks) {
setupRenderingTest(hooks);
setupMirage(hooks);

test('shows crate name and highest stable version', async function (assert) {
let crate = this.server.create('crate', { name: 'foo' });
this.server.create('version', { crate, num: '1.0.0' });
this.server.create('version', { crate, num: '1.2.3', yanked: true });
this.server.create('version', { crate, num: '2.0.0-beta.1' });
this.server.create('version', { crate, num: '1.1.2' });

let store = this.owner.lookup('service:store');
this.crate = await store.findRecord('crate', crate.name);

await render(hbs`<CrateRow @crate={{this.crate}} />`);
assert.dom('[data-test-crate-link]').hasText('foo');
assert.dom('[data-test-version]').hasText('v1.1.2');
assert.dom('[data-test-copy-toml-button]').exists();
});

test('shows crate name and highest version, if there is no stable version available', async function (assert) {
let crate = this.server.create('crate', { name: 'foo' });
this.server.create('version', { crate, num: '1.0.0-beta.1' });
this.server.create('version', { crate, num: '1.0.0-beta.3' });
this.server.create('version', { crate, num: '1.0.0-beta.2' });

let store = this.owner.lookup('service:store');
this.crate = await store.findRecord('crate', crate.name);

await render(hbs`<CrateRow @crate={{this.crate}} />`);
assert.dom('[data-test-crate-link]').hasText('foo');
assert.dom('[data-test-version]').hasText('v1.0.0-beta.3');
assert.dom('[data-test-copy-toml-button]').exists();
});

test('shows crate name and no version if all versions are yanked', async function (assert) {
let crate = this.server.create('crate', { name: 'foo' });
this.server.create('version', { crate, num: '1.0.0', yanked: true });
this.server.create('version', { crate, num: '1.2.3', yanked: true });

let store = this.owner.lookup('service:store');
this.crate = await store.findRecord('crate', crate.name);

await render(hbs`<CrateRow @crate={{this.crate}} />`);
assert.dom('[data-test-crate-link]').hasText('foo');
assert.dom('[data-test-version]').doesNotExist();
assert.dom('[data-test-copy-toml-button]').doesNotExist();
});
});