render: add HTML image tests with align support #3862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current align test was only used for text, but we want to be sure that images can be aligned too. This is why a new test is added to verify that the align attribute is also kept for images. Since the align attribute requires RAW HTML for the <img> tag, the relative_links test has also been updated to check for this usage.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jtgeibel (or someone else) soon. Please see the contribution instructions for more information. |
Turbo87
added
A-backend ⚙️
C-internal 🔧
|
@bors r+ |
|
📌 Commit 6eea612 has been approved by |
|
☀️ Test successful - checks-actions |
bors
added a commit
that referenced
this pull request
Sep 7, 2021
render: fix center image test The image test is actually not representative and will not center the image. This fix helps users discover how to center images and proves that they will be centered on crates.io. Note: I am the original author of this testcase from PR #3862
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was not sure that the
alignproperly was supported for images, so I extended therender.rstests to convince me that it indeed worked as intended.Below is the commit message: