SQL: Fix metadata handling in to_semver_no_prerelease() function

Cargo.toml

@@ -90,8 +90,10 @@ tracing-subscriber = "0.2"
 url = "2.1"
 
 [dev-dependencies]
+bigdecimal = { version = ">= 0.0.10, < 0.2.0" }
 claim = "0.5"
 conduit-test = "0.9.0-alpha.4"
+diesel = { version = "1.4.0", features = ["numeric"] }
 hyper-tls = "0.5"
 lazy_static = "1.0"
 tokio = "1.5.0"

migrations/2021-09-03-132838_fix_to_semver_no_prerelease/down.sql

@@ -0,0 +1,12 @@
+create or replace function to_semver_no_prerelease(text) returns semver_triple
+    immutable
+    language sql
+as
+$$
+SELECT (
+        split_part($1, '.', 1)::numeric,
+        split_part($1, '.', 2)::numeric,
+        split_part(split_part($1, '+', 1), '.', 3)::numeric
+           )::semver_triple
+WHERE strpos($1, '-') = 0
+$$;

migrations/2021-09-03-132838_fix_to_semver_no_prerelease/up.sql

@@ -0,0 +1,19 @@
+create or replace function to_semver_no_prerelease(text) returns semver_triple
+    immutable
+    language sql
+as
+$$
+SELECT (
+        -- 2) then, we extract the major, minor and patch numbers
+        --    (dropping the prerelease part to avoid number conversion errors)
+        split_part(version_without_metadata, '.', 1)::numeric,
+        split_part(version_without_metadata, '.', 2)::numeric,
+        split_part(split_part(version_without_metadata, '-', 1), '.', 3)::numeric
+           )::semver_triple
+FROM (
+    -- 1) first, we split off the release metadata, if it exists
+    SELECT split_part($1, '+', 1) as version_without_metadata
+    ) as vwm
+-- 3) finally, we only return the result if there is no prerelease part
+WHERE strpos(version_without_metadata, '-') = 0
+$$;

src/tests/all.rs

@@ -46,6 +46,7 @@ mod record;
 mod schema_details;
 mod server;
 mod server_binary;
+mod sql;
 mod team;
 mod token;
 mod unhealthy_database;

src/tests/sql/custom_functions.rs

@@ -0,0 +1,39 @@
+use bigdecimal::BigDecimal;
+use diesel::prelude::*;
+use diesel::sql_types::Text;
+use diesel::{select, sql_function};
+
+fn pg_connection() -> PgConnection {
+    let database_url =
+        dotenv::var("TEST_DATABASE_URL").expect("TEST_DATABASE_URL must be set to run tests");
+    let conn = PgConnection::establish(&database_url).unwrap();
+    conn.begin_test_transaction().unwrap();
+    conn
+}
+
+sql_function!(fn to_semver_no_prerelease(x: Text) -> Nullable<Record<(Numeric, Numeric, Numeric)>>);
+
+#[test]
+fn to_semver_no_prerelease_works() {
+    let conn = pg_connection();
+
+    #[track_caller]
+    fn test(conn: &PgConnection, text: &str, expected: Option<(i32, i32, i32)>) {
+        let query = select(to_semver_no_prerelease(text));
+        let result = query
+            .get_result::<Option<(BigDecimal, BigDecimal, BigDecimal)>>(conn)
+            .unwrap();
+
+        let expected = expected.map(|it| (it.0.into(), it.1.into(), it.2.into()));
+        assert_eq!(result, expected);
+    }
+
+    test(&conn, "0.0.0", Some((0, 0, 0)));
+    test(&conn, "1.2.4", Some((1, 2, 4)));
+    test(&conn, "1.2.4+metadata", Some((1, 2, 4)));
+    test(&conn, "1.2.4-beta.3", None);
+
+    // see https://github.com/rust-lang/crates.io/issues/3882
+    test(&conn, "0.4.45+curl-7.78.0", Some((0, 4, 45)));
+    test(&conn, "0.1.4-preview+4.3.2", None);
+}

src/tests/sql/mod.rs

@@ -0,0 +1 @@
+mod custom_functions;