database/versions: Add generated version_no_prerelease column
#3992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
C-internal 🔧
Turbo87
force-pushed
the
generated-column
branch
from
9511a7f to
95dab8f
Compare
|
rebased on top of #3993 to fix the |
Turbo87
force-pushed
the
generated-column
branch
from
95dab8f to
1872202
Compare
bors
added a commit
that referenced
this pull request
Oct 14, 2021
database: Simplify `trigger_versions_set_updated_at` trigger on the `versions` table The only mutable columns in this table are `yanked` and `downloads`, but the trigger should specifically not be used when the `downloads` column changes. That means we're only left with the `yanked` column and can be more specific in the trigger condition. This unblocks #3992, but also generally simplifies the table trigger.
Turbo87
force-pushed
the
generated-column
branch
from
1872202 to
cffbb57
Compare
|
closing in favor of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to speed up the reverse dependencies query, as hinted at in #3886 (comment).
Instead of running
to_semver_no_prerelease(num)in every query, we use a generated column to speed up the query.In my local tests with the imported database dump the query times were previously around 1700ms for the
randcrate, and after this change they consistently dropped down to around 900ms.