Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract cargo-registry-index package #4396

Merged
merged 2 commits into from
Jan 25, 2022
Merged

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Jan 2, 2022

This PR extracts our code to deal with the package index into a dedicated cargo-registry-index crate. This should make it faster to recompile just this part of the code and run the corresponding tests. It also ensures a somewhat clean boundary between the different code areas.

@Turbo87 Turbo87 added A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear labels Jan 2, 2022
@Turbo87 Turbo87 force-pushed the index-crate branch 3 times, most recently from 1a836eb to 2707b85 Compare January 2, 2022 10:11
@bors
Copy link
Contributor

bors commented Jan 13, 2022

☔ The latest upstream changes (presumably #4440) made this pull request unmergeable. Please resolve the merge conflicts.

@Turbo87 Turbo87 force-pushed the index-crate branch 3 times, most recently from a21e8ed to 41bd32d Compare January 20, 2022 21:31
We will extract the `git` module into a dedicated crate in one of the next commits. This would be impossible if the crate had to depend on the main crate, since it would result in a cyclic dependency.
@Turbo87
Copy link
Member Author

Turbo87 commented Jan 25, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Jan 25, 2022

📌 Commit c0d68c3 has been approved by Turbo87

@bors
Copy link
Contributor

bors commented Jan 25, 2022

⌛ Testing commit c0d68c3 with merge f5ddb9d...

@bors
Copy link
Contributor

bors commented Jan 25, 2022

☀️ Test successful - checks-actions
Approved by: Turbo87
Pushing f5ddb9d to master...

@bors bors merged commit f5ddb9d into rust-lang:master Jan 25, 2022
@Turbo87 Turbo87 deleted the index-crate branch January 26, 2022 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants