Use crate.id with links to force ember to load all the crate data #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes rust-lang#331. Thank you @locks!!!! On crate list pages, we had *some* data about each crate, but not keywords. The way the links were constructed, ember saw the partial data that matched and would use that on the crate page instead of reloading the whole crate from the crate show api JSON, which *does* have keywords available. Using the id with the links instead of the whole model forces the request for all the data to happen.
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #331. Thanks to @locks, who knew exactly what the problem was!!!!
On crate list pages, we had some data about each crate, but not
keywords. The way the links were constructed, ember saw the partial data
that matched and would use that on the crate page instead of reloading
the whole crate from the crate show api JSON, which does have keywords
available. Using the id with the links instead of the whole model forces
the request for all the data to happen.