Skip to content

fix: incorrect host when running tests #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2017
Merged

fix: incorrect host when running tests #578

merged 1 commit into from
Feb 26, 2017

Conversation

venkatagiri
Copy link
Contributor

As noted in #493 (comment),
the recorded http-data in src/tests expects "http://alexcrichton-test.s3.amazonaws.com".
But, as the S3_REGION env var is loaded as Some(""),
it matches wrong leading to wrong host "http://alexcrichton-test-.s3.amazonaws.com".
This fixes it by handling match when region is empty.

As noted in #493 (comment),
the recorded `http-data` in `src/tests` expects "http://alexcrichton-test.s3.amazonaws.com".
But, as the `S3_REGION` env var is loaded as `Some("")`,
it matches wrong leading to wrong host "http://alexcrichton-test-.s3.amazonaws.com".
This fixes it by handling match when region is empty.
@carols10cents
Copy link
Member

Looks great!! Thank you!! ❤️

@carols10cents carols10cents merged commit fd7fb05 into rust-lang:master Feb 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants