Define admin users and extend AuthCheck to handle them
#6456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LawnGnome
added
C-enhancement ✨
Turbo87
reviewed
May 10, 2023
Turbo87
reviewed
May 11, 2023
|
Updated per review. Definitely simpler this way, so thanks! I don't love the drilling of |
Turbo87
reviewed
May 22, 2023
This comment was marked as outdated.
This comment was marked as outdated.
Turbo87
approved these changes
Jul 17, 2023
This adds a concept of admin users, who are defined by their GitHub IDs, and allows them to be defined through an environment variable.
This will make it easier to test the logic in the future.
This function can be used to require that the current cookie or token belong to an admin user.
Turbo87
force-pushed
the
define-admins
branch
from
28d359a to
877755b
Compare
|
Closing in favour of #7852. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a concept of admin users, who are defined by their GitHub IDs, and allows them to be defined through an environment variable, falling back to a static list of the current
crates.ioteam.AuthChecknow has a builder method to require that the current cookie or token belong to an admin user.In the future, this will be extended to use Rust's team API for the fallback.