Added a base font size #689
Conversation
|
This PR is not useless! I'm not a CSS or typography expert either, so I did a little research... it looks like the recommended practice for body font size has changed over the years and browser versions, but this Google PageSpeed Insights reference updated in 2015 at least recommends exactly what you've done here ❤️ BUT.... there's a catch. I see that your screenshots include content from doc.crates.io. And I regret to inform you... The content for doc.crates.io actually lives in cargo's repo for Reasons™, and this is terrible because we have to keep the HTML, docs menu, and CSS in sync between the two repos :( Someday hopefully we'll figure out a solution for this, but for now, could you also submit this same change to all.css in cargo's repo as well? Sorry sorry sorry |
Added a base font size See rust-lang/crates.io#689 (ping @carols10cents) A base font size was added to crates.io, here is the same addition for docs.crate.io
I just added a base font size, because it seems there is none right now and it results in a weird display on different browser for the inline code. Here is a screenshot of firefox (same with chrome):
You can see the
rustcandcargo neware really smaller and there is no reason(?). I think a base font size for the site may be better. Here is a screenshot with base font-size:It seems more readable. Sorry if this PR is useless (I'm not sure it's my first PR here and I'm not a CSS master)