-
Notifications
You must be signed in to change notification settings - Fork 648
SQL: Fix metadata handling in to_semver_no_prerelease() function #7317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@paolobarbolini since @LawnGnome is on vacation and you've proven that you know a lot about Postgres, any chance you could take a look at this? :) I'm most concerned about two things:
|
2cae43f
to
a221dee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I forgot this is called to_semver_no_prerelease
, so I deleted my previous review comments:(
Tested locally and it worked well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me, and the tests cover the two variations that are important (dash before plus, and vice versa). 👍
a221dee
to
fcfda15
Compare
I missed the notification 😅.
|
Resolves #3882
This PR is basically reviving #3886, since we now have a generated and stored
semver_no_prerelease
column in theversions
table, which should fix the performance concerns that led to #3886 being initially rejected.