Skip to content

Switch to GitHub IDs #645 #798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from
Closed

Switch to GitHub IDs #645 #798

wants to merge 0 commits into from

Conversation

vignesh-sankaran
Copy link
Contributor

@vignesh-sankaran vignesh-sankaran commented Jun 23, 2017

Testing procedure I used was the following:

  • Log in as a user
  • Upload a crate under that user
  • Log out, and log in as another user
  • Attempt publishing the crate as the prior user
  • Log in as the other user, modify the crate and publish the crate

@carols10cents A couple of things I noticed were that the script exited if an uppercase "Y" was entered, and that there is an assertion that fails if more than 1 crate is being transferred.

As a matter of interest, when is this script utilised?

@vignesh-sankaran vignesh-sankaran changed the title Fix for #645 Switch to GitHub IDs #645 Jun 23, 2017
@vignesh-sankaran
Copy link
Contributor Author

Argh I should learn not to use git push --force, lost my changes

@vignesh-sankaran
Copy link
Contributor Author

Argh sorry for the mess, forgot to branch things out :(

@Turbo87
Copy link
Member

Turbo87 commented Jun 27, 2017

@vignesh-sankaran FWIW you should probably not use your master branch for PRs 😉

@vignesh-sankaran
Copy link
Contributor Author

@Turbo87 I've learned that the hard way now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants