Skip to content

WIP: Fix reverse dependencies query #810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 29, 2017

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Jun 26, 2017

Resolves #306

@carols10cents could you check if this is indeed working as intended? I didn't have any crates in my local env to check and only used the unit tests for verification. Is there some sort of sandbox env that we could deploy this too?

This PR only includes the backend changes for now until we have verified that those work as intended.

@Turbo87 Turbo87 requested a review from carols10cents June 26, 2017 07:43
@Turbo87 Turbo87 force-pushed the reverse-deps branch 3 times, most recently from 5d7acaa to f7103b9 Compare June 26, 2017 15:33
@carols10cents
Copy link
Member

I have a backend setup locally, and we also have staging-crates-io.herokuapp.com that I can deploy to, but there's not too much data there. Will be testing this out in a min!

@Turbo87
Copy link
Member Author

Turbo87 commented Jun 27, 2017

@carols10cents would be awesome if you could deploy this to the staging server. there seem to be enough crates on there to verify if everything works as I imagined.

@carols10cents
Copy link
Member

I just created merge conflicts; I'm going to resolve these, force push, then review/try out/deploy to staging :)

Turbo87 added 2 commits June 28, 2017 20:23

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@sgrif
Copy link
Contributor

sgrif commented Jun 28, 2017

Can you better explain why #306 occurred and how this fixes it in your commit message?

@Turbo87
Copy link
Member Author

Turbo87 commented Jun 28, 2017

@sgrif is the cross reference to #306 (comment) not enough?

@carols10cents carols10cents merged commit 0455a8a into rust-lang:master Jun 29, 2017
@carols10cents
Copy link
Member

@Turbo87 Bad news, good news, then bad news!

I've got this deployed to https://staging-crates-io.herokuapp.com now, and I'm not sure if the backend changes aren't quite working right or if there's frontend stuff that needs to change?

Here's what I'm seeing:

The good news is that the original issue seems to be fixed! That is, if I:

Back to the bad news, this problem happens but it happens on live crates.io too so I'm going to file a new issue 😂 When I:

@carols10cents
Copy link
Member

I'm going to revert the merge on the master branch, but I'm leaving it deployed to staging for you to play with it :)

carols10cents added a commit that referenced this pull request Jun 29, 2017
This reverts commit 0455a8a, reversing
changes made to 1291a87.
@Turbo87
Copy link
Member Author

Turbo87 commented Jun 29, 2017

@carols10cents sorry about the confusion, there was indeed still something missing from this PR which is why it was still marked as WIP. I'll reopen as another PR with the necessary frontend changes.

@Turbo87 Turbo87 deleted the reverse-deps branch June 29, 2017 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants