Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

controllers/user/session: Replace r2d2 with deadpool #8440

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Apr 10, 2024

This changes the order of operations a bit. Previously, we were first doing the GitHub requests and then connecting to the database. Now, we are first connecting to the database before doing the sync OAuth exchange with GitHub. This allows us to move from spawn_blocking() to conn.interact() though, which in turn allows us to get rid of the sync database connection pools soon.

@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Apr 10, 2024
Copy link

codecov bot commented Apr 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 87.61%. Comparing base (48ba166) to head (ddf8c41).
Report is 1 commits behind head on main.

Files Patch % Lines
src/controllers/user/session.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8440   +/-   ##
=======================================
  Coverage   87.61%   87.61%           
=======================================
  Files         272      272           
  Lines       26330    26329    -1     
=======================================
  Hits        23068    23068           
+ Misses       3262     3261    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Turbo87
Copy link
Member Author

Turbo87 commented Apr 10, 2024

@LawnGnome I'll go ahead and merge this to unblock the next PR, but feel free to review after-the-fact :)

@Turbo87 Turbo87 merged commit 77d55e9 into rust-lang:main Apr 10, 2024
8 checks passed
@Turbo87 Turbo87 deleted the deadpool-session branch April 10, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant