controllers/user/session: Replace r2d2
with deadpool
#8440
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the order of operations a bit. Previously, we were first doing the GitHub requests and then connecting to the database. Now, we are first connecting to the database before doing the sync OAuth exchange with GitHub. This allows us to move from
spawn_blocking()
toconn.interact()
though, which in turn allows us to get rid of the sync database connection pools soon.