Rename krate in json to crate #861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was changed when switching from rustc serialize to serde; ember expects the key in the JSON to be "crate" but Rust needs the field in the struct to be named "krate". The tests didn't catch this because we aren't testing the serialized JSON string at all; a round trip through JSON totally worked :-/
|
Seems good. Is there any more comprehensive checking that we can do here? I suspect this isn't the only one as I raised in #801 (comment) |
sgrif
approved these changes
Jul 8, 2017
|
Oh sorry, I somehow missed that one. |
|
Yeah idk since we don't really have end-to-end integration tests or like... golden master tests of the JSON responses :-/ |
|
We had talked a while ago about maybe adding an integration suite that hits the frontend hitting a real backend maybe written in Ruby or something. It might be a good time to move forward with that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was changed when switching from rustc serialize to serde; ember
expects the key in the JSON to be "crate" but Rust needs the field in
the struct to be named "krate". The tests didn't catch this because we
aren't testing the serialized JSON string at all; a round trip through
JSON totally worked :-/
This breaks the reverse dependencies page-- the name of the dependent crate doesn't show up.
I checked everywhere that has
krate:; it looks like all the other places have serde renaming appropriately.Found this while testing on staging before deploying to prod-- @sgrif you around to review?