email: Change from to crates.io <no-reply@crates.io>
#9342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far we had only used `no-reply@crates.io` without a `name` in the `Mailbox`. This changes the `Mailbox` instance to use the configured `domain` as the name, which means that users will see e.g. "crates.io" as the sender instead of "no-reply@crates.io".
Turbo87
added
C-enhancement ✨
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9342 +/- ##
=======================================
Coverage 89.19% 89.19%
=======================================
Files 282 282
Lines 28964 28966 +2
=======================================
+ Hits 25834 25837 +3
+ Misses 3130 3129 -1 ☔ View full report in Codecov by Sentry. |
Turbo87
added a commit
to Turbo87/crates.io
that referenced
this pull request
Aug 29, 2024
These were caused by a conflict between rust-lang#9342 and rust-lang#9341. Should've rebased first... 🙈
Merged
Turbo87
added a commit
that referenced
this pull request
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far we had only used
no-reply@crates.iowithout anamein theMailbox. This changes theMailboxinstance to use the configureddomainas the name, which means that users will see e.g. "crates.io" as the sender instead of "no-reply@crates.io".