Skip to content

Expose the default_version on the API #9741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 25, 2024

Conversation

eth3lbert
Copy link
Contributor

@eth3lbert eth3lbert commented Oct 23, 2024

This PR exposes the default_version on the API, which was introduced in #8484.
I implements this into multiple commits, which should be easier to follow and inspect :)

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 98.63946% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.81%. Comparing base (f4c2cb9) to head (4256700).
Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
src/views.rs 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9741      +/-   ##
==========================================
+ Coverage   88.77%   88.81%   +0.04%     
==========================================
  Files         289      289              
  Lines       29701    29829     +128     
==========================================
+ Hits        26367    26494     +127     
- Misses       3334     3335       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eth3lbert eth3lbert force-pushed the krate-default-version branch from 3a464f3 to 0744b6f Compare October 23, 2024 20:42
@eth3lbert eth3lbert force-pushed the krate-default-version branch from 0744b6f to 4c7785f Compare October 23, 2024 20:57
@Turbo87 Turbo87 added C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works A-backend ⚙️ labels Oct 24, 2024
@Turbo87 Turbo87 merged commit 8b42804 into rust-lang:main Oct 25, 2024
10 checks passed
@eth3lbert eth3lbert deleted the krate-default-version branch October 25, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend ⚙️ C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants