Exclude num_no_build from versions.csv db-dump #9786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9786 +/- ##
=======================================
Coverage 88.83% 88.83%
=======================================
Files 289 289
Lines 29854 29854
=======================================
Hits 26521 26521
Misses 3333 3333 ☔ View full report in Codecov by Sentry. |
Turbo87
approved these changes
Oct 29, 2024
This was referenced Nov 27, 2024
Turbo87
added a commit
to Turbo87/crates.io
that referenced
this pull request
Nov 29, 2024
This reverts commit b975538.
Turbo87
added a commit
that referenced
this pull request
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In versions.csv, the num_no_build column is identical to num but without build metadata. So if num="1.0.0+example" then num_no_build="1.0.0".
It exists in the database only for the purpose of defining a
uniqueconstraint on(crate_id, num_no_build). See #9756.But there is no reason to include it in db-dump.tar.gz because in downstream code it's trivial to reconstruct from the value of num if needed.