Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

axum-extra: Use json!() macro #9960

Merged
merged 1 commit into from
Nov 16, 2024
Merged

axum-extra: Use json!() macro #9960

merged 1 commit into from
Nov 16, 2024

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Nov 16, 2024

This seems a bit easier to use than the Json(json!(...)) construct and is apparently even a bit faster since it does not need to allocate as much memory.

Related:

@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Nov 16, 2024
@Turbo87 Turbo87 force-pushed the json-macro branch 4 times, most recently from 1d41fe7 to be67b7b Compare November 16, 2024 10:57
@Turbo87 Turbo87 enabled auto-merge (squash) November 16, 2024 10:57
This seems a bit easier to use than the `Json(json!(...))` construct and is apparently even a bit faster since it does not need to allocate as much memory.
Copy link

codecov bot commented Nov 16, 2024

Codecov Report

Attention: Patch coverage is 92.94118% with 6 lines in your changes missing coverage. Please review.

Project coverage is 89.16%. Comparing base (fa7b413) to head (deccdc1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/controllers/site_metadata.rs 0.00% 2 Missing ⚠️
src/controllers/team.rs 0.00% 2 Missing ⚠️
src/controllers/krate/metadata.rs 87.50% 1 Missing ⚠️
src/controllers/version/downloads.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9960   +/-   ##
=======================================
  Coverage   89.16%   89.16%           
=======================================
  Files         292      292           
  Lines       30316    30316           
=======================================
  Hits        27031    27031           
  Misses       3285     3285           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Turbo87 Turbo87 merged commit 64c1aa7 into rust-lang:main Nov 16, 2024
10 checks passed
@Turbo87 Turbo87 deleted the json-macro branch November 16, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant