Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rust crate axum to v0.7.9 #9969

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Update Rust crate axum to v0.7.9 #9969

merged 1 commit into from
Nov 18, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 16, 2024

This PR contains the following updates:

Package Type Update Change
axum dependencies patch =0.7.8 -> =0.7.9

Release Notes

tokio-rs/axum (axum)

v0.7.9: axum - v0.7.9

Compare Source

  • fixed: Avoid setting content-length before middleware (#​3031)

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@mladedav
Copy link

I checked what's happening and it seems that axum changed its behavior in some cases when the body is wrapped by a layer. One of them is the compression layer (though other layers could most likely do the same thing), when compression is applied, it seems to have always used chunked transfer but with the new patch version it uses chunked transfer instead of content length even if no accept-encoding was received and so no compression was done.

If you think all your clients should be able to handle chunked transfer, then the change can be ignored. I've opened an issue on axum's side so if you want more updates, they will be posted there.

@Turbo87
Copy link
Member

Turbo87 commented Nov 18, 2024

I've rebased this on top of #9994. let's see if that "fixes" it :)

@renovate renovate bot force-pushed the renovate/axum-0.x branch from 50ea345 to 7539ca1 Compare November 18, 2024 21:33
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.17%. Comparing base (33cb168) to head (7539ca1).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9969      +/-   ##
==========================================
- Coverage   89.18%   89.17%   -0.01%     
==========================================
  Files         294      294              
  Lines       30713    30713              
==========================================
- Hits        27390    27389       -1     
- Misses       3323     3324       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@Turbo87 Turbo87 merged commit 88f856d into main Nov 18, 2024
10 checks passed
@Turbo87 Turbo87 deleted the renovate/axum-0.x branch November 18, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants