Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Godbolt Command #77

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add Godbolt Command #77

wants to merge 4 commits into from

Conversation

tinaun
Copy link
Contributor

@tinaun tinaun commented Feb 2, 2021

Depends on #90

src/commands.rs Outdated Show resolved Hide resolved
src/commands.rs Outdated Show resolved Hide resolved
src/commands.rs Outdated Show resolved Hide resolved
@technetos
Copy link
Member

Im all for adding a godbolt command but there are additional changes lumped into this PR. If you would like to see the godbolt command added please make a PR adding just that functionality.

src/main.rs Outdated Show resolved Hide resolved
@khionu
Copy link
Member

khionu commented Jun 20, 2021

Did you run cargo fmt on this?

@@ -148,6 +149,35 @@ fn app() -> Result<(), Error> {
});
}

cmds.add("?godbolt flags={} version={} ```\ncode```", |args| {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to not use a closure here unless its necessary. Please move these into a fn and pass the fn pointer here instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants