add CoC update message... command #89
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khionu
suggested changes
Jun 12, 2021
khionu
suggested changes
Jun 20, 2021
| .ok_or("unable to retrieve message param")?; | ||
|
|
||
| let welcome_message_is_not_cached = { | ||
| let data = args.cx.data.read(); |
There was a problem hiding this comment.
Say this function was ran twice in parallel. This check could be hit twice before the message is stored in data, which could cause parallel attempts to populate it.
There was a problem hiding this comment.
You are absolutely correct, nice catch, this is a problem and I will address it.
| .message(args.cx, u64::from_str(&message_id)?)?; | ||
|
|
||
| cache_welcome_message(args.cx, message)?; | ||
| } else { |
There was a problem hiding this comment.
Instead of failing, maybe we should somehow have it post the message? Might be tricky, ergonomically speaking, because of the lack of awareness of which channel to post in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
CoC update message...command to update the content of the existing welcome message