Skip to content

Show different message than 'Go to latest version' on pre-releases #1044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Kixiron opened this issue Sep 12, 2020 · 1 comment · Fixed by #1045
Closed

Show different message than 'Go to latest version' on pre-releases #1044

Kixiron opened this issue Sep 12, 2020 · 1 comment · Fixed by #1045
Labels
A-frontend Area: Web frontend C-enhancement Category: This is a new feature E-easy Effort: Should be easy to implement and would make a good first PR P-low Low priority issues

Comments

@Kixiron
Copy link
Member

Kixiron commented Sep 12, 2020

We automatically redirect to the first non-prerelease version when available, but on pre-release versions we still display the "Go to latest version" box in the tab, see sqlx v0.4.0-beta.1
@Kixiron Kixiron added C-bug Category: This is a bug E-easy Effort: Should be easy to implement and would make a good first PR P-low Low priority issues A-frontend Area: Web frontend labels Sep 12, 2020
@Nemo157
Copy link
Member

Nemo157 commented Sep 12, 2020

I think the link/warning should still be displayed, but changed wording to something like "Go to stable version".

@jyn514 jyn514 added C-enhancement Category: This is a new feature and removed C-bug Category: This is a bug labels Sep 12, 2020
@Kixiron Kixiron changed the title Don't show 'Go to latest version' on pre-releases Show different message than 'Go to latest version' on pre-releases Sep 13, 2020
robinhundt added a commit to robinhundt/docs.rs that referenced this issue Sep 13, 2020
@robinhundt
Display "Go to latest stable" for pre-release
769e8cc 
closes rust-lang#1044
robinhundt added a commit to robinhundt/docs.rs that referenced this issue Sep 13, 2020
@robinhundt
Display "Go to latest stable" for pre-release
c257af1 
closes rust-lang#1044
robinhundt added a commit to robinhundt/docs.rs that referenced this issue Sep 13, 2020
@robinhundt
Display "Go to latest stable" for pre-release
fb06f95 
closes rust-lang#1044
@robinhundt robinhundt mentioned this issue Sep 13, 2020
Merged
robinhundt added a commit to robinhundt/docs.rs that referenced this issue Sep 13, 2020
@robinhundt
Display "Go to latest stable" for pre-release
60f801d 
closes rust-lang#1044
robinhundt added a commit to robinhundt/docs.rs that referenced this issue Sep 13, 2020
@robinhundt
Display "Go to latest stable" for pre-release
9a877de 
closes rust-lang#1044
robinhundt added a commit to robinhundt/docs.rs that referenced this issue Sep 13, 2020
@robinhundt
Display "Go to latest stable" for pre-release
cadd04e 
closes rust-lang#1044
robinhundt added a commit to robinhundt/docs.rs that referenced this issue Sep 13, 2020
@robinhundt
Display "Go to latest stable" for pre-release
e3b09c9 
closes rust-lang#1044
jyn514 pushed a commit that referenced this issue Sep 13, 2020
@robinhundt
Display "Go to latest stable" for pre-release
b2b7458 
closes #1044
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-frontend Area: Web frontend C-enhancement Category: This is a new feature E-easy Effort: Should be easy to implement and would make a good first PR P-low Low priority issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Display "Go to latest stable" for pre-release robinhundt/docs.rs
3 participants
@Nemo157 @jyn514 @Kixiron