Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUSTSEC-2020-0053: dirs is unmaintained, use dirs-next instead #1102

Closed
github-actions bot opened this issue Oct 17, 2020 · 8 comments · Fixed by #1264 or #1332
Closed

RUSTSEC-2020-0053: dirs is unmaintained, use dirs-next instead #1102

github-actions bot opened this issue Oct 17, 2020 · 8 comments · Fixed by #1264 or #1332
Labels
C-technical-debt Category: This makes the code harder to read and modify, but has no impact on end users E-easy Effort: Should be easy to implement and would make a good first PR

Comments

@github-actions
Copy link

dirs is unmaintained, use dirs-next instead

Details
Status unmaintained
Package dirs
Version 2.0.2
URL https://github.com/dirs-dev/dirs-rs
Date 2020-10-16

The dirs crate is not maintained any more;
use dirs-next instead.

See advisory page for additional details.

@jyn514
Copy link
Member

jyn514 commented Oct 22, 2020

$ cargo tree -p dirs -i
dirs v2.0.2
└── rusoto_credential v0.45.0
    ├── docs-rs v0.6.0 (/home/joshua/src/rust/docs.rs)
    ├── rusoto_core v0.45.0
    │   ├── docs-rs v0.6.0 (/home/joshua/src/rust/docs.rs)
    │   └── rusoto_s3 v0.45.0
    │       └── docs-rs v0.6.0 (/home/joshua/src/rust/docs.rs)
    └── rusoto_signature v0.45.0
        └── rusoto_core v0.45.0 (*)

There's no later release of rusoto, so this is blocked until then.

@jyn514 jyn514 added S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work. C-technical-debt Category: This makes the code harder to read and modify, but has no impact on end users labels Oct 22, 2020
@coolreader18
Copy link
Contributor

Looks like rusoto has updated since then

@jyn514
Copy link
Member

jyn514 commented Jan 24, 2021

Great! @coolreader18 are you interested in making a PR to update rusoto? :)

@jyn514 jyn514 added E-easy Effort: Should be easy to implement and would make a good first PR and removed S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work. labels Jan 24, 2021
@coolreader18
Copy link
Contributor

Sure!

@jyn514
Copy link
Member

jyn514 commented Feb 16, 2021

This was reverted in #1278.

@jyn514 jyn514 reopened this Feb 16, 2021
@coolreader18
Copy link
Contributor

Oh, yikes, that's not good. I didn't really make any changes to docs.rs' code in that PR, so is it an upstream issue in tokio? Or if it's related to building crates; rustwide?

@coolreader18
Copy link
Contributor

coolreader18 commented Feb 16, 2021

Oh, or maybe it's tokio-rs/tokio#3477? Maybe something with process stdio not being dropped? nevermind, that was fixed in the version pinned in Cargo.lock

@Nemo157
Copy link
Member

Nemo157 commented Feb 16, 2021

I'm attempting to bisect the dependency update locally, see if I can track down which update caused it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-technical-debt Category: This makes the code harder to read and modify, but has no impact on end users E-easy Effort: Should be easy to implement and would make a good first PR
Projects
None yet
3 participants