Revert "Upgrade rusoto (and tokio)" #1278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyn514
added
S-waiting-on-review
Closed
Nemo157
approved these changes
Feb 16, 2021
This was referenced Mar 1, 2021
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1264. This was the likely cause of the outage this evening (#1277), there was an ongoing memory leak:
. The proximate cause was building the stm32 crates, which have a higher memory limit than normal and put us over the edge, but the server shouldn't have been resting at 10 GB RSS in the first place, it's usually much lower around 4 GB.
The site going down could have been avoided with #657. That would have delayed builds indefinitely, although it's possible we were leaking so much memory the site would still have eventually crashed.
r? @pietroalbini