-
Notifications
You must be signed in to change notification settings - Fork 212
Mobile: Opening rustdoc hamburger menu overlaps rustdoc header #1121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I've confirmed this problem still exists. Would it be an issue if I picked it up? The immediate fix (adjusting the I'll take care to not go overboard as #1120 proposes something that could make this component not long for the world. |
@arusahni go for it :) this seems to be a docs.rs specific bug, so I'd start by finding why this is different from normal docs that rustdoc generates. |
@jyn514 after some comparison, it boils down to it being because of the docs.rs shell. The sidebar is a EDIT: It appears that the selector for this element changed, so the override we had in place was no longer functional. |
This corrects a bug where the CSS selcetor to reposition the top of the rustdoc sidebar was no longer applied to the element. It also updates the magic number to be less magic. Fixes rust-lang#1121
These (and some Clippy warnings) are addressed in PR #1233. |
This corrects a bug where the CSS selcetor to reposition the top of the rustdoc sidebar was no longer applied to the element. It also updates the magic number to be less magic. Fixes rust-lang#1121
This corrects a bug where the CSS selcetor to reposition the top of the rustdoc sidebar was no longer applied to the element. It also updates the magic number to be less magic. Fixes #1121
Steps to reproduce:
Expected result:
Rustdoc's crate header is not obscured by the menu.
Actual result:
The header is obscured by the menu.
https://docs.rs/ureq/1.5.1/ureq/index.html
vs https://doc.rust-lang.org/std/vec/struct.Vec.html
(noticed while writing up #1120 )
The text was updated successfully, but these errors were encountered: