-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Static resources corresponding to 20210305-1.52.0-nightly-caca2121f are missing #1305
Comments
I reproduced this on my local instance:
But then it goes on to build the next crate in the queue and because the nightly version hasn't changed it skips acquiring the essential files. |
so it seems related to 5e5f407 |
Yep, I'm not sure why though, rust-lang/rust#82545 was merged 8 days ago so the files should be there, unless this has been reverted in the meantime? I'm going to try making a change so that if essential files fail we don't continue building crates so that the impact of failures like this won't be so bad, but once rust-lang/rust#82803 is merged and used this shouldn't reoccur. |
Reduces the impact from failures like rust-lang#1305, rather than continuing to build crates with the failing toolchain we will just stop building crates until an admin has time to investigate the cause.
Thanks for quickly looking into this! However, it is not obvious to me what I need to do to get the docs fixed — please let me know. |
Nothing 😁, there's a bug fix we need to deploy, then we'll rebuild all affected documentation. |
Oh, cool! I thought I’d have to push a new version once the bug is fixed 🙂 |
For this specific thing I even assume we don't even need to rebuild the docs, because they are already referencing to the correctly hashed files. |
Ah yes, |
This has been fixed. |
We didn't try to copy the files until yesterday: #1301. Last night was the first time docs.rs tried to run a build with the new toolchain. |
https://docs.rs/serde/1.0.123/serde/ looks fine, but https://docs.rs/serde/1.0.124/serde/ seems to fail to load a bunch of stuff.
The text was updated successfully, but these errors were encountered: