Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search broken for hecs 0.5.1, various iterations of rapier 0.8.0 #1370

Closed
Ralith opened this issue Apr 19, 2021 · 8 comments
Closed

Search broken for hecs 0.5.1, various iterations of rapier 0.8.0 #1370

Ralith opened this issue Apr 19, 2021 · 8 comments
Labels
A-builds Area: Building the documentation for a crate C-bug Category: This is a bug

Comments

@Ralith
Copy link

Ralith commented Apr 19, 2021

Searches in these crates return no results. Related to #1369?

@Ralith
Copy link
Author

Ralith commented Apr 20, 2021

cpal 0.13.3 is also affected.

@jyn514
Copy link
Member

jyn514 commented Apr 20, 2021

The issue is we uploaded all files with the resource-suffix for a few releases:

$ aws s3 ls s3://rust-docs-rs | grep search-index.*js
2021-03-21 20:50:08        120 search-index-20210321-1.53.0-nightly-f82664191.js
2021-03-22 21:00:32        120 search-index-20210322-1.53.0-nightly-5d04957a4.js
2021-03-23 21:17:49        120 search-index-20210323-1.53.0-nightly-673d0db5e.js
2021-03-24 20:52:42        120 search-index-20210324-1.53.0-nightly-07e0e2ec2.js
2021-04-12 20:52:24        120 search-index-20210412-1.53.0-nightly-d0695c908.js

When I reverted #1324 in #1340, they broke search for all crates built by that toolchain. I don't have permissions to remove those files myself, but @pietroalbini should.

@jyn514 jyn514 added A-builds Area: Building the documentation for a crate C-bug Category: This is a bug labels Apr 20, 2021
@pietroalbini
Copy link
Member

Removed those files!

@Nemo157
Copy link
Member

Nemo157 commented Apr 20, 2021

hecs search is still broken, it may be that the CDN needs invalidating too.

@jyn514
Copy link
Member

jyn514 commented Apr 20, 2021

@Nemo157 it's not enough to invalidate the path of the shared files, each individual crate has to be invalidated since we give precedence to global files over local ones.

@jyn514
Copy link
Member

jyn514 commented Apr 20, 2021

I wonder if it makes sense to add a query string to the global resources with the version of docs.rs they were built by. Then we wouldn't have to keep sending cache invalidations.

@jyn514
Copy link
Member

jyn514 commented Apr 20, 2021

Oh wait, that requires rustdoc support :/ maybe we could generate a redirect from the page rustdoc links to? Like redirect crates-2021-03-24.js -> crates-2021-03-24.js?docsrs_version=2021-04-01

@jyn514
Copy link
Member

jyn514 commented Apr 20, 2021

We just did a mass invalidation, this should fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-builds Area: Building the documentation for a crate C-bug Category: This is a bug
Projects
None yet
Development

No branches or pull requests

4 participants