Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search is broken for minifb #1386

Closed
john01dav opened this issue Apr 30, 2021 · 4 comments
Closed

Search is broken for minifb #1386

john01dav opened this issue Apr 30, 2021 · 4 comments

Comments

@john01dav
Copy link

When I attempt to search for an item via the search bar in any crate on docs.rs, I get the following failure mode:
Demonstration of issue where it simply hangs on "Loading search results..." and the search bar is empty

In the Javascript console the following error message is present:

Content Security Policy: The page’s settings blocked the loading of a resource at inline (“default-src”). storage-change-detection.html:11:1

They appear to be related, and possibly related to #1333, or #234. This error takes place in Firefox 88.0 on Fedora Linux. It does not take place with locally-generated rustdocs.

@Nemo157
Copy link
Member

Nemo157 commented Apr 30, 2021

The script in storage-change-detection.html should be unrelated, that just means the docs.rs header/footer doesn't change theme when you change it in rustdoc instantly.

For minifb 0.19.3 I see another error in the console:

GEThttps://docs.rs/minifb/0.19.3/search-index-20210322-1.53.0-nightly-5d04957a4.js
[HTTP/2 404 Not Found 363ms]

Probably related to #1377/#1370.

@john01dav
Copy link
Author

The script in storage-change-detection.html should be unrelated, that just means the docs.rs header/footer doesn't change theme when you change it in rustdoc instantly.

For minifb 0.19.3 I see another error in the console:

GEThttps://docs.rs/minifb/0.19.3/search-index-20210322-1.53.0-nightly-5d04957a4.js
[HTTP/2 404 Not Found 363ms]

Probably related to #1377/#1370.

I just tested with some random crates, and they seem to work. It seems like it doesn't work on all the crates I've been using recently, so I thought that it was more broad than it is.

@john01dav john01dav changed the title Content security Policy in Firefox 88 blocks searching in docs.rs, but not normal rustdoc Search is broken for minifb Apr 30, 2021
@jyn514
Copy link
Member

jyn514 commented Jun 12, 2021

https://docs.rs/minifb/0.19.3/search-index-20210322-1.53.0-nightly-5d04957a4.js is missing for some reason. I'll rebuild the crate.

@jyn514
Copy link
Member

jyn514 commented Jun 12, 2021

Requeued and rebuilt: https://docs.rs/minifb/0.19.3/minifb/?search=menu

@jyn514 jyn514 closed this as completed Jun 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants