Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

big crates are slow to use with new archive-storage #1528

Closed
syphar opened this issue Oct 22, 2021 · 4 comments
Closed

big crates are slow to use with new archive-storage #1528

syphar opened this issue Oct 22, 2021 · 4 comments
Assignees
Labels
A-backend Area: Webserver backend C-bug Category: This is a bug

Comments

@syphar
Copy link
Member

syphar commented Oct 22, 2021

For crates with many files we have a performance regression.

Example is stm32ral, which has 1.2 Million files in the archives.

Currently we are reading the whole index from disk for every file-exists or get-from-archive request, which might take too much time.

@syphar syphar added A-backend Area: Webserver backend C-bug Category: This is a bug labels Oct 22, 2021
@syphar syphar self-assigned this Oct 23, 2021
@jyn514
Copy link
Member

jyn514 commented Oct 27, 2021

@syphar did you want to keep this open to track not having to read the full index into memory?

@syphar
Copy link
Member Author

syphar commented Oct 27, 2021

@syphar did you want to keep this open to track not having to read the full index into memory?

yes. But most likely it's good enough afterwards for the 99% case on docs.rs.

more optimizations would involve a new index format and I'll gather more data in a benchmark and the S3 inventory first

@jyn514
Copy link
Member

jyn514 commented Nov 13, 2021

Current status for 99th percentile:
image

The deploy of #1541 happened at 13:38 and the spike at 14:05 is me testing https://docs.rs/stm32ral/0.7.0/stm32ral/.

@syphar
Copy link
Member Author

syphar commented Aug 3, 2023

After:

this is solved.

#2179 will drop the old code

@syphar syphar closed this as completed Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend Area: Webserver backend C-bug Category: This is a bug
Projects
None yet
Development

No branches or pull requests

2 participants