Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opening a crates versionless url links to prerelease versions #223

Closed
Nemo157 opened this issue Jul 19, 2018 · 4 comments · Fixed by #565
Closed

Opening a crates versionless url links to prerelease versions #223

Nemo157 opened this issue Jul 19, 2018 · 4 comments · Fixed by #565
Labels
C-bug Category: This is a bug E-easy Effort: Should be easy to implement and would make a good first PR

Comments

@Nemo157
Copy link
Member

Nemo157 commented Jul 19, 2018

I just pushed a test crate to https://docs.rs/nemo157, there was a 0.3.0 version published previously and I just added a 0.3.1-pre version. I expected the versionless url to still redirect to the latest non-prerelease version, but instead it links to the prerelease version; and explicitly going to https://docs.rs/nemo157/0.3.0/nemo157/ shows a bright orange "Go to latest version" link.

I think for the purposes of promoting a stable ecosystem it would be best to treat prerelease versions as ineligible to be the latest version unless a crate has no normal versions available. Having them still listed under the versions for the crate and allowing them to be linked to directly would still be useful.
@jyn514 jyn514 mentioned this issue Jan 2, 2020
Closed
This was referenced Jan 10, 2020
Closed
Closed
Merged
@udoprog
Copy link

udoprog commented Jan 13, 2020 •
edited
Loading

I'd like to boost the signal on this a bit. It's causing a bit of a yanking party in tokio-rs/tokio#2036!

@jyn514 jyn514 added C-bug Category: This is a bug E-easy Effort: Should be easy to implement and would make a good first PR labels Jan 13, 2020
@jyn514
Copy link
Member

jyn514 commented Jan 13, 2020

@Nemo157 the test crate makes this much faster to debug, thanks :)

@jyn514
Copy link
Member

jyn514 commented Jan 13, 2020

I'm going to try and also fix #221 at the same time.

@jyn514
Copy link
Member

jyn514 commented Jan 14, 2020

This is mostly fixed, I'm just trying to solve #395 at the same time. If I don't get it in the next half hour or so I'll just make a PR without.

jyn514 added a commit to jyn514/docs.rs that referenced this issue Jan 14, 2020
@jyn514
Fix various bugs in match_version
8199571 
- Ignore yanked versions
- Ignore pre-release versions
- Add lots of tests

Note: this now queries `releases.version` instead of `crates.versions`
so that I have accessed to `releases.yanked`. This _shouldn't_ affect
behavior, but if a previous bug set `crates.versions` to something
different, it will no longer be seen.

Closes rust-lang#223, rust-lang#221
@jyn514 jyn514 mentioned this issue Jan 14, 2020
Merged
jyn514 added a commit that referenced this issue Jan 23, 2020
@jyn514
Fix various bugs in match_version
644e03d 
- Ignore yanked versions
- Ignore pre-release versions
- Add lots of tests

Note: this now queries `releases.version` instead of `crates.versions`
so that I have accessed to `releases.yanked`. This _shouldn't_ affect
behavior, but if a previous bug set `crates.versions` to something
different, it will no longer be seen.

Closes #223, #221
hecrj added a commit to iced-rs/iced that referenced this issue Feb 3, 2020
@hecrj
Fix docs.rs links
f5186f3 
Related issue: rust-lang/docs.rs#223
@sunjay sunjay mentioned this issue Feb 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug E-easy Effort: Should be easy to implement and would make a good first PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix various bugs in match_version jyn514/docs.rs
3 participants
@Nemo157 @udoprog @jyn514