Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top bar covers target of anchor link #403

Closed
bluss opened this issue Sep 4, 2019 · 6 comments
Closed

Top bar covers target of anchor link #403

bluss opened this issue Sep 4, 2019 · 6 comments

Comments

@bluss
Copy link
Member

bluss commented Sep 4, 2019

If you go to search inside a specific crate, the search results for methods are focused in a way so that the method you want to see is covered by the top bar.

One example is this link: https://docs.rs/chrono/0.4.9/chrono/struct.Date.html#method.timezone

To reproduce

  1. Go to https://docs.rs/chrono/0.4.9/
  2. Search for timezone
  3. Click the chrono::Date::timezone result (a method)
  4. The method is focused, aligned flush to the top of the view — this is beneath the top bar, so it's not actually visible — scroll up a bit to see the method you clicked

Tested in browser: Firefox 68.0.2 and Chromium 76.0.3809

@GuillaumeGomez
Copy link
Member

It's a known issue that should have been fixed a while ago by #358 I should maybe check another time...

@bluss
Copy link
Member Author

bluss commented Sep 4, 2019

I see. Since I see this in chromium and firefox, it seems persistent. Platform is Linux 64-bit. I guess that change has been applied, docs rs lists 2019-07-30 as its version

@GuillaumeGomez
Copy link
Member

I don't know if the fix has been deployed actually. Any idea @onur ?

@PonasKovas
Copy link

This is extremely annoying, any progress?

@jyn514
Copy link
Member

jyn514 commented Mar 16, 2020

This was fixed a while ago but regressed in #637. The fix is waiting on review in #640

@jyn514
Copy link
Member

jyn514 commented Mar 17, 2020

Reverted #637: #642

@jyn514 jyn514 closed this as completed Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants