Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imageproc docs fail to build #408

Closed
theotherphil opened this issue Sep 15, 2019 · 3 comments
Closed

imageproc docs fail to build #408

theotherphil opened this issue Sep 15, 2019 · 3 comments
Assignees

Comments

@theotherphil
Copy link

theotherphil commented Sep 15, 2019

https://docs.rs/crate/imageproc/0.19.1/builds/185422

The docs build fails while attempting to document the sdl2-sys dependency https://github.com/Rust-SDL2/rust-sdl2/blob/master/sdl2-sys/build.rs#L50

This isn't an issue with docs.rs per se, but I was hoping there would be a known workaround for dependencies that docs.rs cannot build. This dependency is only required if a feature is enabled, so I'll disable that feature in package.metadata.docs.rs for now to get some documentation.

@pietroalbini
Copy link
Member

I'll take a look on Monday if nobody else from the team beats me to it.

@pietroalbini
Copy link
Member

I'm sorry but you'll have to disable that feature. One of your dependencies is trying to download with curl something from the internet in its build script.

While it's technically possible for me to fix that build failure (looks like the curl CLI is missing?) an upcoming docs.rs change is going to remove all network access from builds. That's going to break your crate anyway, so there is no point in hacking a fix right now.

@theotherphil
Copy link
Author

Ok, thanks for looking. Disabling network access sounds pretty sensible!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants