Skip to content

"Source" tab is shown even when no source is present #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pietroalbini opened this issue Dec 13, 2019 · 1 comment
Open

"Source" tab is shown even when no source is present #520

pietroalbini opened this issue Dec 13, 2019 · 1 comment
Labels
A-frontend Area: Web frontend C-bug Category: This is a bug E-easy Effort: Should be easy to implement and would make a good first PR P-low Low priority issues

Comments

@pietroalbini
Copy link
Member

#519 fixed a panic happening when visiting a crate's source page when no source was available (due to a build failure), by showing a 404 page instead.

Still, the link to the source tab is unconditionally present in the navbar, even when we know it will lead to a 404 page. We should fix this by hiding the link in those cases.

@pietroalbini pietroalbini added the C-bug Category: This is a bug label Dec 13, 2019
@jyn514 jyn514 added A-frontend Area: Web frontend E-easy Effort: Should be easy to implement and would make a good first PR labels Jul 6, 2020
@jyn514 jyn514 added the P-medium Medium priority label Jul 14, 2020
@jyn514
Copy link
Member

jyn514 commented Aug 15, 2020

This is now much less of an issue due to #928 (since there will always be source present from now on). However there will still be 404s for crates built before that PR.

@jyn514 jyn514 added P-low Low priority issues and removed P-medium Medium priority labels Aug 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend Area: Web frontend C-bug Category: This is a bug E-easy Effort: Should be easy to implement and would make a good first PR P-low Low priority issues
Projects
None yet
Development

No branches or pull requests

2 participants