Skip to content

"Releases by Stars" should only show one crate per github repository #985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jonasbb opened this issue Aug 20, 2020 · 7 comments · Fixed by #989
Open

"Releases by Stars" should only show one crate per github repository #985

jonasbb opened this issue Aug 20, 2020 · 7 comments · Fixed by #989
Labels
A-frontend Area: Web frontend E-medium Effort: This requires a fair amount of work mentor This has instructions for getting started P-low Low priority issues

Comments

@jonasbb
Copy link

jonasbb commented Aug 20, 2020

Thank you for providing this great site for the Rust ecosystem.
docs.rs has the page where is shows all releases sorted by Github stars. The pages have become so crowded that it is very hard to see anything in them anymore. As an admittedly extreme example, the pages from page 9 to page 210 contain different versions of the rustc-ap-* crates.

I see two problems there:

  1. The page lists all versions of the same crate and assigns them the same number of stars. This makes all the versions appear next to each other in the list. This just crowds the list without contributing much information.
  2. Some crates like the deno and rustc-ap-* ones are part of a collection of crates which are all managed in the same repository. As such they all have the same number of stars and appear next to each other in the list. This can also be on purpose. Grouping into some repository entry, which can list multiple crates could also be a solution.
@jyn514
Copy link
Member

jyn514 commented Aug 20, 2020

Would it help if we deduplicated the releases and showed at most 1 release per crate? Then instead of 10 copies of deno, you'd get each deno crate once, taking up 1 page instead of 9.

@jyn514 jyn514 added the A-frontend Area: Web frontend label Aug 20, 2020
@jonasbb
Copy link
Author

jonasbb commented Aug 20, 2020

Yes, I think that would already help a lot.

@jyn514
Copy link
Member

jyn514 commented Aug 21, 2020

Mentoring instructions: In

WHERE (NOT $3) OR (releases.build_status = FALSE AND releases.is_library = TRUE)

add AND crates.latest_version_id = releases.id. Please also add a test for the new functionality. There are examples near
#[test]
.

@jyn514 jyn514 added E-easy Effort: Should be easy to implement and would make a good first PR mentor This has instructions for getting started labels Aug 21, 2020
@jyn514 jyn514 self-assigned this Aug 21, 2020
@jyn514
Copy link
Member

jyn514 commented Aug 21, 2020

Hmm, #989 addressed the first point but not the second, it would be nice to group crates by workspace. That seems like a lot more work, though.

@jyn514 jyn514 reopened this Aug 21, 2020
@Nemo157
Copy link
Member

Nemo157 commented Aug 21, 2020

One way to do it might be to group by repository url (especially since that's what determines the "stars").

@jyn514 jyn514 added the P-low Low priority issues label Aug 21, 2020
@jyn514 jyn514 changed the title "Releases by Stars" is unreadable due to overcrowding "Releases by Stars" should only show one crate per github repository Aug 21, 2020
@jonasbb
Copy link
Author

jonasbb commented Aug 21, 2020

Oh wow. Thank you for implementing that so quickly :) I wanted to take a look at implementing it this evening.

I consider this issue solved for now. Grouping crates by repository was just an idea, but for most crates/repositories not that relevant Feel free to keep the issue open though if you like the idea.

@jyn514
Copy link
Member

jyn514 commented Aug 21, 2020

If you're looking for other opportunities to contribute let me know! Anything marked E-easy or mentor would be a good first issue :)

@jyn514 jyn514 removed their assignment Oct 22, 2020
@jyn514 jyn514 added E-medium Effort: This requires a fair amount of work and removed E-easy Effort: Should be easy to implement and would make a good first PR labels Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend Area: Web frontend E-medium Effort: This requires a fair amount of work mentor This has instructions for getting started P-low Low priority issues
Projects
None yet
3 participants