Show at most one crate from the same repo in /releases search #1375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyn514
added
A-backend
jyn514
changed the title
syphar
reviewed
Apr 21, 2021
src/db/migrate.rs
Outdated
| @@ -736,6 +736,11 @@ pub fn migrate(version: Option<Version>, conn: &mut Client) -> crate::error::Res | |||
| "ALTER TABLE builds RENAME COLUMN cratesfyi_version TO docsrs_version", | |||
| "ALTER TABLE builds RENAME COLUMN docsrs_version TO cratesfyi_version", | |||
| ), | |||
| migration!( | |||
| context, 30, "Ensure repos don't have multiple ids", | |||
There was a problem hiding this comment.
Suggested change
| context, 30, "Ensure repos don't have multiple ids", | |
| context, 30, "Ensure repos don't have multiple names", |
| releases.release_time, | ||
| releases.rustdoc_status, | ||
| repositories.stars, | ||
| rank() OVER (PARTITION BY repository_id ORDER BY release_time DESC) AS rank |
There was a problem hiding this comment.
this will filter all releases without repository (where releases.repository_id is NULL) except the most recent one.
| ((NOT $3) OR (releases.build_status = FALSE AND releases.is_library = TRUE)) | ||
| AND {0} IS NOT NULL | ||
| ) i | ||
| WHERE rank = 1 |
There was a problem hiding this comment.
Suggested change
| WHERE rank = 1 | |
| WHERE i.repository_id IS NULL OR rank = 1 |
|
other thought, only to be safe: It was an intended change that this grouping will happen for all release lists? |
syphar
added
S-waiting-on-author
Before, it would create two different repos with the same name, which messed up searching.
This avoids showing rustc_ap_* three dozen times in a row. TODO: is it correct to pick the latest published crate? Is there a way to find the "main" crate from a repository?
|
I reverted the unique constraint after the discussion we had on discord:
|
|
Sure, seems reasonable. I won't have time to work on this any time soon anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids showing rustc_ap_* three dozen times in a row.
TODO: is it correct to pick the latest published crate? Is there a way
to find the "main" crate from a repository?
The first commit caught several bugs and should go in separately even if this doesn't land.
Fixes #985.