Fixed typo in "go to latest version" tooltip #1094
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR rust-lang#1045 introduced a small typo in the "go to latest version" tooltips where a space was missing after the crate name.
Sure, seems reasonable. The link is broken though - did you mean to say add a label? |
jyn514
added
the
S-waiting-on-deploy
|
Oops, I wanted to link to the hacktoberfest page. The rules of the hacktoberfest were changed so that it is opt-in for maintainers. Either the "hacktoberfest" topic is added to a repository or individual PR's are labelled as "hacktoberfest-accepted" https://hacktoberfest.digitalocean.com/hacktoberfest-update 😊 |
|
It looks like clippy is using the topic, and quickly checking their PR list they don't seem to be getting spam from it, so seems ok to add (and will help me get closer to completing it too 😁). |
jyn514
added
the
hacktoberfest
|
Done! |
jyn514
removed
the
S-waiting-on-deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #1045 introduced a small typo in the "go to latest version" tooltips
where a space was missing after the crate name.
@maintainers : How do you feel about adding the hacktoberfest topic to the repo so that PR's count towards the event? 😊