Skip to content

Fix error handling for search #1115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2020
Merged

Fix error handling for search #1115

merged 1 commit into from
Oct 22, 2020

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Oct 22, 2020

  • Return 500, not 400, for internal errors
  • Return an error for internal errors in search instead of 'not found'

Found while working on #1101.

r? @Kixiron

@jyn514
Fix error handling
a117eb8 
- Return 500, not 400, for internal errors
- Return an error for internal errors in search, not 'not found'
@jyn514 jyn514 added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Oct 22, 2020
@jyn514 jyn514 merged commit 9c27d80 into rust-lang:master Oct 22, 2020
@jyn514 jyn514 deleted the error-handling branch October 22, 2020 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kixiron Kixiron Kixiron approved these changes

Assignees
No one assigned
Labels
S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jyn514 @Kixiron