Skip to content

Remove whitespace beside docs.rs text #1183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2020
Merged

Conversation

pickfire
Copy link
Contributor

Last time I removed whitespace somewhere else, this time in menu.

Re-fix #1160

r? @jyn514

Last time I removed whitespace somewhere else, this time in menu.
@pickfire
Copy link
Contributor Author

I wonder if there is some sort of templating that automatically removes all these unnecessary whitespaces.

@jyn514
Copy link
Member

jyn514 commented Nov 17, 2020

Can you post a screenshot of the issue this is fixing?

@jyn514 jyn514 added A-frontend Area: Web frontend S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Nov 17, 2020
@pickfire
Copy link
Contributor Author

https://github.com/Keats/tera/pull/430/files maybe we could use {{-? Not sure if {%- is doing what I think it is.

@pickfire
Copy link
Contributor Author

Should be the same as the old one since I probably remove another whitespace last time.

image

@jyn514 jyn514 added S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Nov 17, 2020
@jyn514
Copy link
Member

jyn514 commented Nov 17, 2020

Seems fine, then.

@jyn514 jyn514 merged commit c0718f5 into rust-lang:master Nov 17, 2020
@pickfire pickfire deleted the patch-1 branch November 17, 2020 14:14
@pickfire
Copy link
Contributor Author

How long does it take for the change to be reflected in the current docs.rs?

@jyn514
Copy link
Member

jyn514 commented Nov 17, 2020

@pickfire the deployments are irregular; 'when I find time for it'. For smaller PRs I usually wait until a few larger ones land, since each deployment has about 10 seconds of downtime until we fix #1150.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend Area: Web frontend S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants