Skip to content

Regression prevention #1195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2020
Merged

Regression prevention #1195

merged 1 commit into from
Nov 28, 2020

Conversation

GuillaumeGomez
Copy link
Member

Just realized that I could add a test to prevent to have to send other PRs like #1194 :)

@GuillaumeGomez GuillaumeGomez added the A-frontend Area: Web frontend label Nov 28, 2020
@jyn514
Copy link
Member

jyn514 commented Nov 28, 2020

I don't know why I didn't think of that earlier 😆 great idea!

@GuillaumeGomez
Copy link
Member Author

Arf hold on, seems like github didn't realize the first commit was already in.

@GuillaumeGomez
Copy link
Member Author

After a rebase, github realized its mistake and made the commit disappear. :3

@jyn514 jyn514 merged commit b728426 into rust-lang:master Nov 28, 2020
@GuillaumeGomez GuillaumeGomez deleted the regression-prevention branch November 28, 2020 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-frontend Area: Web frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuillaumeGomez @jyn514